Write to env the controller/action values for other middleware to use #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthv
approved these changes
Jul 17, 2025
forest-bot
added a commit
that referenced
this pull request
Jul 17, 2025
# [9.15.0](v9.14.7...v9.15.0) (2025-07-17) ### Features * **router:** make controller and action available to middleware ([#533](#533)) ([57804f6](57804f6))
|
🎉 This PR is included in version 9.15.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using certain middleware (in our case, prometheus-exporter), it is expected that the action and controller parameters are set by the router, as it's the case for the default Rails router.
This MR would ensure that these are filled in using reasonable values, without affecting anything else, and allow us to export metrics from Forest controllers not differently from what we do with our custom controllers.